[PAPI] Use "Timeout" for setting up a connectionTimeout #20176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geropl
commented
Sep 4, 2024
| for await (const response of factory({ | ||
| signal: abort.signal, | ||
| signal: AbortSignal.any([abort.signal, connectionTimeout.signal()!]), |
There was a problem hiding this comment.
TIL learned about AbortSignal.any, kind of made my day 😆
geropl
force-pushed
the
gpl/ft/debug-unreceived-data
branch
from
b056f95 to
0e40007
Compare
|
@geropl maybe we should get the |
geropl
force-pushed
the
gpl/ft/debug-unreceived-data
branch
from
0e40007 to
a4bcacf
Compare
|
/unhold |
Mostly tests and comments. I will make sure to merge them somewhere. |
filiptronicek
pushed a commit
that referenced
this pull request
Sep 5, 2024
roboquat
pushed a commit
that referenced
this pull request
Sep 6, 2024
* [PAPI] Retry steams upon not receiving data for 10 seconds * [PAPI] Retry steams upon not receiving data for 10 seconds (#20176) * debug message * Do not listen for ws updates globally and do not timeout for those calls * Timeout signal as a getter * use ff for disablement * accesor fn => getter * send empty initial data in papi for global ws watch requests --------- Co-authored-by: Gero Posmyk-Leinemann <gero@gitpod.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold