Skip to content

Enforce minimum scopes in the UI #20217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

Enforce minimum scopes in the UI #20217

merged 1 commit into from
Sep 16, 2024

Conversation

filiptronicek
Copy link
Member

Description

Does the below, or, explained with words, enforces on the UI that scopes we require for providers are not uncheckable.

image

This PR also unifies the scope definitions and puts them all into the public-api package, linking to it from both the dashboard and server.

Related Issue(s)

Fixes #

How to test

  • Log in with an SCM
  • Look at the permission settings modal on the Integrations page

@filiptronicek filiptronicek requested review from a team as code owners September 13, 2024 11:31
geropl
geropl approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🧹 work, thank you @filiptronicek !

@roboquat roboquat merged commit 35f53b9 into main Sep 16, 2024
34 checks passed
@roboquat roboquat deleted the ft/enforce-minimum-scopes branch September 16, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
size/XL team: team-enterprise team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filiptronicek @geropl @roboquat