Cell Disabled mode #20222
Merged
Cell Disabled mode #20222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Sep 16, 2024
Comment on lines
+298
to
+312
| const isCellDisabled = await getExperimentsClientForBackend().getValueAsync( | ||
| "cell_disabled", | ||
| false, | ||
| {}, | ||
| ); | ||
| if ( | ||
| isCellDisabled && | ||
| requestContext.requestMethod === "gitpod.v1.UserService/getAuthenticatedUser" | ||
| ) { | ||
| const error = self.apiConverter.toError( | ||
| new ApplicationError(ErrorCodes.CELL_EXPIRED, "Cell is disabled"), | ||
| ); | ||
| done(error); | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
This part does the heavy lifting
geropl
reviewed
Sep 17, 2024
geropl
reviewed
Sep 18, 2024
| @@ -382,6 +382,11 @@ export class GitpodServerImpl implements GitpodServerWithTracing, Disposable { | |||
| } | |||
|
|
|||
| private async checkUser(methodName?: string, logPayload?: {}, ctx?: LogContext): Promise<User> { | |||
| const cellDisabled = await getExperimentsClientForBackend().getValueAsync("cell_disabled", false, {}); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a way for us to expire POV cells, controlled by the new
cell_disabledfeature flag.Related Issue(s)
Fixes ENT-794
How to test
Visit the following preview env. You can also try flipping the feature flag mentioned above and see what it does.
https://ft-disable8a89f3dd88.preview.gitpod-dev.com/