Skip to content

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Sep 18, 2024

Description

This PR introduces a new feature to set a hashed user ID cookie for analytics purposes on specific Gitpod domains. The cookie is set during the JWT refresh process, ensuring it's always up-to-date for authenticated users.

Changes:

  • Added setHashedUserIdCookie method to SessionHandler class
  • Integrated cookie setting logic into jwtSessionConvertor method
  • Implemented domain-specific checks for cookie setting

Followup of #20226

Related Issue(s)

Fixes ENT-801

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, waiting for preview env to test once more

@Siddhant-K-code
Copy link
Member Author

Confirmed it here (internal conv.) & its working

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 92f3ec0 into main Sep 18, 2024
18 checks passed
@roboquat roboquat deleted the siddhant/ent-801-store-hasheduserid-in-cookie-storage branch September 18, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants