Skip to content

Disable JetBrains local ports forwarding with FF #20274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Disable JetBrains local ports forwarding with FF #20274

merged 4 commits into from
Oct 11, 2024

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Oct 8, 2024

Description

Related Issue(s)

Fixes ENT-826

How to test

  • Try to enable or disable FeatureFlag
  • Restart or create workspace with IntelliJ IDEA (latest or stable, but not pinned) after update FF (needs server aware FF changes, i.e. after 5 minutes)
  • Check ports view, ports should not expose to local (or access localhost:<port>)
Disabled Ports Exposing Enabled
SCR-20241009-opju SCR-20241009-oros

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat added size/M and removed size/S labels Oct 9, 2024
@mustard-mh mustard-mh changed the title WIP Disable JetBrains local ports exposing with FF Oct 9, 2024
@mustard-mh mustard-mh marked this pull request as ready for review October 9, 2024 08:43
@mustard-mh mustard-mh requested review from a team as code owners October 9, 2024 08:43
@mustard-mh mustard-mh requested a review from iQQBot October 9, 2024 08:48
@mustard-mh
Copy link
Contributor Author

@iQQBot could you have a look if you have time?

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With disable feature

image

Without disable feature

image

@mustard-mh mustard-mh changed the title Disable JetBrains local ports exposing with FF Disable JetBrains local ports forwarding with FF Oct 10, 2024
@mustard-mh
Copy link
Contributor Author

Feedback addressed, right now we only disable local ports forwarding, other ports features should work well like before, i.e.

  • Show notification when ports is opened
  • Able to click on 'Open in Browser' on notifications or in ports view double click URLs

There's a known issue that 'Copy Web URL' is not working ENT-863, we will address it separately

@iQQBot could you please help test again 🙏

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With disable feature

image

Manually add port forward, it also works

image image

without disabled feature

image the local port forward adds automatically

@roboquat roboquat merged commit b429e93 into main Oct 11, 2024
18 checks passed
@roboquat roboquat deleted the hw/jb-pf branch October 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants