[JetBrains] improve handling of client connection termination #20288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Oct 11, 2024
...rains/gateway-plugin/src/main/kotlin/io/gitpod/jetbrains/gateway/GitpodConnectionProvider.kt
Outdated
Show resolved
Hide resolved
akosyakov
reviewed
Oct 11, 2024
| connectionLifetime.terminate() | ||
| GlobalScope.launch { | ||
| // Delay for 5 seconds to wait the thinClient actually close | ||
| delay(5000) |
There was a problem hiding this comment.
how do we know 5secs is enough, is there a triggere to which we can reliable bind instead?
There was a problem hiding this comment.
I don't think thinClient will block for 5 more seconds (unless UI freeze maybe?). From java Doc, there's no other public listeners available, I found clientProcessTerminated but it's private
mustard-mh
force-pushed
the
hw/ENT-804
branch
from
921131c to
6c1488e
Compare
|
@iQQBot could you please help test this PR 🙏 ? Here's the context of recent change:
You could consider the screenshot below as 'connection provider' and you could check also this Loom 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes ENT-804
How to test
Smoke test Gitpod Gateway Plugin
gp timeout set 1mConnection Closed by Gateway: Restart the connect via JetBrains GatewayDocumentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold