Skip to content

Conversation

filiptronicek
Copy link
Member

Description

Adds our garbage collection policy for prebuilds as a notice in the organization prebuilds list
image

This is displayed at all times if the number of displayed prebuilds is > 1. This was done to reduce confusion when onboarding.

Related Issue(s)

Fixes CLC-838

How to test

  1. Join my org
  2. Take a gander at /prebuilds

@mustard-mh
Copy link
Contributor

mustard-mh commented Oct 24, 2024

@filiptronicek It looks good when the list or prebuilds are fewer, but once prebuilds are used then the lists will not be fewer? And users will not aware of this message on the bottom of the list. Do you think we could have something marked in db that a prebuild is out-dated / deleted and show it? Or not necessary on current PR?

@filiptronicek
Copy link
Member Author

@mustard-mh the thinking here is that if users are looking for a prebuild, they will naturally scroll down to find it. There, we'll educate them with this message. I don't think it's worth it to implement new APIs/change the current listPrebuilds just to have a warning somewhere.
Were you thinking about persisting all prebuilds forever in the DB, and when garbage collecting, just deleting their contents instead of also their DB entries?

@mustard-mh
Copy link
Contributor

@mustard-mh the thinking here is that if users are looking for a prebuild, they will naturally scroll down to find it. There, we'll educate them with this message. I don't think it's worth it to implement new APIs/change the current listPrebuilds just to have a warning somewhere.

@filiptronicek Thanks, the explanation makes sense.

Were you thinking about persisting all prebuilds forever in the DB, and when garbage collecting, just deleting their contents instead of also their DB entries?

No, I was wrong.

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I once checked preview and it looks good as well (but can't access it now with error ERR_TOO_MANY_REDIRECTS maybe relates to dev telepresence mode?)

@roboquat roboquat merged commit a836f97 into main Oct 24, 2024
33 checks passed
@roboquat roboquat deleted the ft/prebuild-gc-notice branch October 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants