Skip to content

[supervisor] Fix subscription leaks in PortsStatus #20332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2024
Merged

[supervisor] Fix subscription leaks in PortsStatus #20332

merged 2 commits into from
Oct 30, 2024

Conversation

filiptronicek
Copy link
Member

Description

We have seen a lot of errors yesterday on catfood about our hitting our subscription limit for the PortsService of the supervisor.

Related Issue(s)

Fixes CLC-890

How to test

  1. Try using the local companion to forward ports against the preview environment

/hold

@filiptronicek
Copy link
Member Author

Let's go

image

@filiptronicek filiptronicek marked this pull request as ready for review October 30, 2024 17:31
@filiptronicek filiptronicek requested review from a team as code owners October 30, 2024 17:31
geropl
geropl approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@roboquat roboquat merged commit 14a1894 into main Oct 30, 2024
33 checks passed
@roboquat roboquat deleted the ft/local-companion-properly-cancel-streams branch October 30, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
size/XS team: team-enterprise team: team-experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filiptronicek @geropl @roboquat