Skip to content

[ws-manager] don't ever set PodRejected if WorkspaceConditionEverReady=true #20372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024
Merged

[ws-manager] don't ever set PodRejected if WorkspaceConditionEverReady=true #20372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions components/ws-manager-mk2/controllers/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,14 @@ func (r *WorkspaceReconciler) updateWorkspaceStatus(ctx context.Context, workspa
if failure != "" && !workspace.IsConditionTrue(workspacev1.WorkspaceConditionPodRejected) {
// Check: A situation where we want to retry?
if isPodRejected(pod) {
// This is a situation where we want to re-create the pod!
log.Info("workspace scheduling failed", "workspace", workspace.Name, "reason", failure)
workspace.Status.SetCondition(workspacev1.NewWorkspaceConditionPodRejected(failure, metav1.ConditionTrue))
r.Recorder.Event(workspace, corev1.EventTypeWarning, "PodRejected", failure)
if !workspace.IsConditionTrue(workspacev1.WorkspaceConditionEverReady) {
// This is a situation where we want to re-create the pod!
log.Info("workspace got rejected", "workspace", workspace.Name, "reason", failure)
workspace.Status.SetCondition(workspacev1.NewWorkspaceConditionPodRejected(failure, metav1.ConditionTrue))
r.Recorder.Event(workspace, corev1.EventTypeWarning, "PodRejected", failure)
} else {
log.Info("workspace got rejected, but we don't handle it, because EveryReady=true", "workspace", workspace.Name, "reason", failure)
}
}
}

Expand Down
Loading