Add permission check for Insights page and don't show it in the menu for non-owners #20593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for non-owners Tool: gitpod/catfood.gitpod.cloud
geropl
reviewed
Feb 10, 2025
| @@ -71,7 +75,11 @@ export const Insights = () => { | |||
|
|
|||
| {errorMessage && ( | |||
| <Alert type="error" className="mt-4"> | |||
| {errorMessage instanceof Error ? errorMessage.message : "An error occurred."} | |||
| {isLackingPermissions | |||
| ? "You don't have permission to access this organization's insights." | |||
There was a problem hiding this comment.
Suggested change
| ? "You don't have permission to access this organization's insights." | |
| ? "You don't have `owner` permission to access this organization's insights." |
There was a problem hiding this comment.
Mentioning the role makes this information for tangible and actionable.
There was a problem hiding this comment.
Sounds great! Gave it a bit more formatting pizzaz to match other places in the dashboard and pushed as b0f3011 (#20593).
geropl
approved these changes
Feb 10, 2025
Co-authored-by: Gero Posmyk-Leinemann <gero@gitpod.io> Tool: gitpod/catfood.gitpod.cloud
Tool: gitpod/catfood.gitpod.cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes CLC-1141
How to test
https://ft-insightb31360f5bd.preview.gitpod-dev.com/insights
/hold