Skip to content

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Apr 22, 2025

Description

This PR refactors the main application header Menu for improved responsiveness and updates the workspace start page with conditional UI elements.

Fixes GRO-808

Menu header Starting page
image image

How to test

  • Verify header layout on different screen sizes (desktop and mobile).
  • Test with relevant customer feature flag enabled and disabled to check conditional UI elements.
  • Check visibility of conditional branding in header and on start page.
  • Verify "Feedback" link visibility in the user menu dropdown under appropriate conditions.
  • Confirm "Admin" link visibility for admin users.

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Siddhant. Thanks for taking this on!

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit d3348ed into main Apr 22, 2025
19 of 20 checks passed
@roboquat roboquat deleted the siddhant/gro-808-gitpod-classic-needs-to-be-visibly-marked-as-gitpod-classic branch April 22, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants