Skip to content

Redact args in the logs of audit log service #20853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Redact args in the logs of audit log service #20853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion components/server/src/audit/AuditLogService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,16 @@ export class AuditLogService {
action: method,
args: argsScrubbed,
};
log.info("audit", new TrustedValue(logEntry));
// The args param contains workspace IDs and other sensitive data. Since
// it's quite hard to detect them, best way is to simply not log it at
// all. It's still part of the audit database but does not appear in the
// component logs.
const logEntryForLogging = {
...logEntry,
args: ["[redacted]"],
};

log.info("audit", new TrustedValue(logEntryForLogging));
await this.dbAuditLog.recordAuditLog(logEntry);
}

Expand Down
Loading