[supervisor] avoid auto exposing the same port multiple times #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related? #2423 |
svenefftinge
reviewed
Dec 7, 2020
akosyakov
force-pushed
the
ak/auto_expose_port
branch
from
b3767d0 to
426c0a1
Compare
akosyakov
force-pushed
the
ak/auto_expose_port
branch
from
426c0a1 to
7f93a2a
Compare
csweichel
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It can happen that exposed ports update takes long and meantime other configured/served updates can happen. It creates the pressure and can lead to poor ports availability. This PR makes sure that the same port can be auto exposed by configured/served ports only once if global port did not change, i.e. if local port was not bound/unbound to/from localhost.
How to test