[docker] Introduce socket activated docker-up #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because that would break the network namespace setup.
csweichel
force-pushed
the
cw/docker-skt-act
branch
from
134e62a
to
de49126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides
dockerevery workspace without the need to calldocker-up. Instead of simply running a Docker daemon in every workspace, we do something akin to systemd's socket activation. When someone tries to use Docker (i.e. writes to/var/run/docker.sock), supervisor starts the Docker daemon and forwards the socket. The Docker daemon gets started in a supervisor terminal.To make this work easier, and also enable supervisor's role within the workspace (reaper, terminator of processes during shutdown), supervisor now runs as UID 0. Terminals, the IDE and other child processes are still started as Gitpod user.
How to test
docker run --rm -it alpine:latest/.supervisor/supervisor terminal listshould show thedocker-upprocess