Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4699] Handle error situations around /headless-logs endpoint #4734

Merged
merged 4 commits into from
Jul 9, 2021
Merged

[#4699] Handle error situations around /headless-logs endpoint #4734

merged 4 commits into from
Jul 9, 2021

Conversation

geropl
Copy link
Member

@geropl geropl commented Jul 7, 2021 •
edited
Loading

Fixes #4699.

Test

  1. create and environment variable: https://gpl-4699-headless-log.staging.gitpod-dev.com/workspaces/
  • name: PREBUILD_PARAMS
  • value: 100_1s_1m_success
  • repo: gitpod-io/gitpod
  1. run a prebuild: https://gpl-4699-headless-log.staging.gitpod-dev.com/#prebuild/https://github.com/gitpod-io/gitpod/tree/gpl/test-prebuild
  • notice how logs work

@geropl geropl requested a review from AlexTugarev July 8, 2021 15:26
@geropl geropl marked this pull request as ready for review July 8, 2021 15:26
@geropl geropl requested review from a team and akosyakov and removed request for a team July 8, 2021 15:26
@AlexTugarev
Copy link
Member

AlexTugarev commented Jul 9, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-gpl-4699-headless-log.9

AlexTugarev
AlexTugarev approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@AlexTugarev AlexTugarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! 👍🏻

Please have a look a the comments left.

@geropl
[server] /headless-logs: Handle tasks without terminals
c40b8bb 
It turns out the tasks API of `supervisor` return `TaskStatus`s without existing terminals. We now check for this case and consider the workspace as "not ready yet" to make sure we present clients a coherent view.
@geropl geropl merged commit 95224cc into main Jul 9, 2021
@geropl geropl deleted the gpl/4699-headless-log branch July 9, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexTugarev AlexTugarev AlexTugarev approved these changes

@akosyakov akosyakov Awaiting requested review from akosyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/headless-logs: unhandled request on prebuild
2 participants
@geropl @AlexTugarev