Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code] remove oldest machine resources on max payload error #4778

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Jul 13, 2021

  • /werft with-clean-slate-deployment

What it does

Change in Gitpod Code: gitpod-io/openvscode-server@a17670b

How to test

The second commit limits the max payload for machine resource to 2 machines. So if you start 3-4 workspaces you should see only 2 machines (#3 and #4) in synced machines view (F1 -> Open View -> Synced Machines), first 2 machines should be removed. I will drop the last commit before merging.

@akosyakov akosyakov requested review from a team, corneliusludmann and fntlnz and removed request for a team July 13, 2021 03:58
@akosyakov akosyakov changed the title Ak/machine res [code] remove oldest machine resources on max payload error Jul 13, 2021
@corneliusludmann
Copy link
Contributor

corneliusludmann commented Jul 14, 2021

/werft run

👍 started the job as gitpod-build-ak-machine-res.7

Copy link
Contributor

@corneliusludmann corneliusludmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works at advertised. Ready to merge after removing the “limit machines to reproduce” commit.

@akosyakov
Copy link
Member Author

akosyakov commented Jul 14, 2021

/werft run

👍 started the job as gitpod-build-ak-machine-res.9

@akosyakov
Copy link
Member Author

akosyakov commented Jul 14, 2021

/werft run

👍 started the job as gitpod-build-ak-machine-res.10

@akosyakov
Copy link
Member Author

akosyakov commented Jul 15, 2021

/werft run

👍 started the job as gitpod-build-ak-machine-res.11

@akosyakov akosyakov merged commit c060c81 into main Jul 15, 2021
@akosyakov akosyakov deleted the ak/machine_res branch July 15, 2021 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[code] Remove "machine resources" when deleting a workspace
2 participants