Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image-builder] Support whitelisted registries in GP layer build #5010

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented Jul 29, 2021

fixes #5007

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #5010 (0eecc83) into main (479abb7) will increase coverage by 6.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           main   #5010      +/-   ##
=======================================
+ Coverage      0   6.53%   +6.53%     
=======================================
  Files         0       3       +3     
  Lines         0     979     +979     
=======================================
+ Hits          0      64      +64     
- Misses        0     911     +911     
- Partials      0       4       +4     
Flag Coverage Δ
components-image-builder-mk3-app 6.53% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...image-builder-mk3/pkg/orchestrator/orchestrator.go 0.00% <0.00%> (ø)
components/image-builder/pkg/resolve/resolve.go 34.78% <0.00%> (ø)
...ents/image-builder-mk3/pkg/orchestrator/monitor.go 11.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479abb7...0eecc83. Read the comment docs.

@csweichel csweichel requested review from aledbf and removed request for rl-gitpod July 29, 2021 15:49
@csweichel csweichel marked this pull request as ready for review July 29, 2021 15:49
@aledbf
Copy link
Member

aledbf commented Jul 29, 2021

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 117fff94d403c2106decdadd6bf1952011056fda

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, csweichel

Associated issue: #5007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a68cf50 into main Jul 29, 2021
@roboquat roboquat deleted the cw/fix-mk3-auth branch July 29, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[image-builder-mk3] Do not assume the two builds use the same registry
3 participants