Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Remove feature flag for desktop IDEs #6505

Merged
merged 2 commits into from
Nov 8, 2021
Merged

[dashboard] Remove feature flag for desktop IDEs #6505

merged 2 commits into from
Nov 8, 2021

Conversation

corneliusludmann
Copy link
Contributor

@corneliusludmann corneliusludmann commented Nov 2, 2021 •
edited
Loading

Description

This PR removes the check that hides the desktop IDE preferences for non-admin users.

image

To Do

  • Set proper feedback issue link

Related Issue(s)

Fixes #6485

How to test

Open the preferences page as a not-admin user (remove the role in the admin page) and make sure the desktop IDE settings are present.

Release Notes

Open up JetBrains desktop IDE feature (BETA) for all users

/no-cc

@corneliusludmann corneliusludmann force-pushed the clu/open-up-jetbrains-6485 branch 3 times, most recently from 7319465 to f9a8935 Compare November 5, 2021 10:26
@corneliusludmann corneliusludmann mentioned this pull request Nov 5, 2021
Closed
@corneliusludmann corneliusludmann marked this pull request as ready for review November 5, 2021 11:06
@corneliusludmann
Copy link
Contributor Author

Rebased on main and removed merge conflict. ✔️

@laushinka
Copy link
Contributor

laushinka commented Nov 8, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-clu-open-up-jetbrains-6485.6

@laushinka
Copy link
Contributor

laushinka commented Nov 8, 2021 •
edited
Loading

The preview env worked as expected even though the build failed.
/lgtm but I will hold in case the failure is something that needs to be looked into. Feel free to unhold if it's not relevant.
Edit: Forgot that merging is blocked anyway when the build doesn't pass.

@corneliusludmann
Copy link
Contributor Author

Thanks, @laushinka! For some reason, the lgtm label didn't make it.

I will restart a slate deployment since it seems that is related to the deployment after the rebase.

@corneliusludmann
Copy link
Contributor Author

werft job is green now

@laushinka
Copy link
Contributor

/lgtm

@roboquat roboquat added the lgtm label Nov 8, 2021
@roboquat
Copy link
Contributor

roboquat commented Nov 8, 2021

LGTM label has been added.

Git tree hash: 4dbedf5da2dc02a3e4e00a67913973c254c8263f

@roboquat
Copy link
Contributor

roboquat commented Nov 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laushinka

Associated issue: #6485

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit a90e378 into main Nov 8, 2021
@roboquat roboquat deleted the clu/open-up-jetbrains-6485 branch November 8, 2021 10:53
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Nov 19, 2021
@roboquat roboquat added the deployed Change is completely running in production label Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@laushinka laushinka

Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open up JetBrains without admin flag (feature preview flag)
3 participants
@corneliusludmann @laushinka @roboquat