Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jetbrains] Add PyCharm IDE #7004

Merged
merged 1 commit into from
Dec 2, 2021
Merged

[jetbrains] Add PyCharm IDE #7004

merged 1 commit into from
Dec 2, 2021

Conversation

corneliusludmann
Copy link
Contributor

Description

This PR adds the desktop IDE PyCharm.

image

What's not included

  • This PR does not include an update of the GitHub action that checks for image updates. Since I'm working on improving this currently anyways, it does not make sense to add this now.
  • This PR re-uses the PyCharm logo from Wikimedia. That allows us to deploy this without a meta update. We should add the logo soon as well (this is planned to serve from IDE components as well in the near future).

How to test

Go to the preferences page and select PyCharm. Start a workspace and make sure you are able to run the Code With Me command.

Release Notes

Add PyCharm desktop IDE.

@roboquat roboquat added release-note team: IDE team: workspace Issue belongs to the Workspace team size/M labels Dec 1, 2021
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #7004 (d6ff681) into main (8bdc71a) will decrease coverage by 13.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7004       +/-   ##
==========================================
- Coverage   19.04%   5.84%   -13.21%     
==========================================
  Files           2      13       +11     
  Lines         168    1147      +979     
==========================================
+ Hits           32      67       +35     
- Misses        134    1079      +945     
+ Partials        2       1        -1     
Flag Coverage Δ
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?
installer-raw-app 5.84% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go
installer/pkg/components/ws-manager/role.go 0.00% <0.00%> (ø)
installer/pkg/components/ws-manager/rolebinding.go 0.00% <0.00%> (ø)
...components/ws-manager/unpriviledged-rolebinding.go 0.00% <0.00%> (ø)
installer/pkg/common/objects.go 0.00% <0.00%> (ø)
installer/pkg/common/common.go 4.74% <0.00%> (ø)
installer/pkg/components/ws-manager/deployment.go 0.00% <0.00%> (ø)
installer/pkg/common/storage.go 0.00% <0.00%> (ø)
installer/pkg/common/render.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdc71a...d6ff681. Read the comment docs.

OrderKey: pointer.String("06"),
Title: "PyCharm",
Type: typeDesktop,
Logo: "https://upload.wikimedia.org/wikipedia/commons/1/1d/PyCharm_Icon.svg", // TODO(clu): Serve logo from our own components instead of using this wikimedia URL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

type: "desktop"
logo: "https://upload.wikimedia.org/wikipedia/commons/1/1d/PyCharm_Icon.svg"
notes: ["While in beta, when you open a workspace with PyCharm you will need to use the password “gitpod”."]
image: {{ (include "gitpod.comp.imageFull" (dict "root" $ "gp" $gp "comp" $gp.components.workspace.desktopIdeImages.pycharm)) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add label RC 2021.3?

@akosyakov
Copy link
Member

/lgtm
/approve no-issue
/hold

just in case if you want to change label

@roboquat
Copy link
Contributor

roboquat commented Dec 1, 2021

LGTM label has been added.

Git tree hash: 365591c3f6c45edf28d1bd7c89380e6a86cfc107

@csweichel
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

roboquat commented Dec 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, csweichel

Associated issue requirement bypassed by: akosyakov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 64539bf into main Dec 2, 2021
@roboquat roboquat deleted the clu/pycharm branch December 2, 2021 08:57
@loujaybee loujaybee linked an issue Dec 2, 2021 that may be closed by this pull request
2 tasks
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: workspace Workspace team change is running in production release-note size/M team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PyCharm Support
4 participants