Skip to content

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Dec 15, 2021

Description

Related Issue(s)

Fixes #6896

How to test

  1. Open a repo in the preview environment: https://track-git-commands.staging.gitpod-dev.com/#https://github.com/gitpod-io/template-python-flask
  2. Open Segment
  3. In the Gitpod workspace, open a terminal and execute a command requiring the cred manager, for instance git clone https://github.com/filiptronicek/test /tmp/repo- note that this will error out, but that doesn't matter, it should still register in the debugger
  4. View the events in Segment, you should see a git_command there somewhere (if none is present, wait a couple of seconds)
  5. Profit 💵

Release Notes

Adds analytic tracking to git commands requiring the git credential manager (remote-facing commands), such as:
- `git clone` (for private repositories)
- `git fetch` (for private repositories)
- `git pull` (for private repositories)
- `git push` (for all repositories)

Documentation

/werft analytics=segment|TEZnsG4QbLSxLfHfNieLYGF4cDwyFWoe

@akosyakov
Copy link
Member Author

akosyakov commented Dec 15, 2021

/werft run

👍 started the job as gitpod-build-track-git-commands.1

@iQQBot iQQBot force-pushed the track_git_commands branch from 4391df7 to 1cfba7e Compare December 16, 2021 10:13
@akosyakov
Copy link
Member Author

@iQQBot just to be clear @filiptronicek is working on this issue? Did you sync with him?

It is fine reviewing other PRs, but contributing should be aligned with the author.

@iQQBot iQQBot force-pushed the track_git_commands branch from cb47ede to 66e2676 Compare December 16, 2021 14:24
@gitpod-io gitpod-io deleted a comment from codecov bot Dec 16, 2021
@filiptronicek
Copy link
Member

filiptronicek commented Dec 16, 2021

@akosyakov I am indeed working on it, @iQQBot helped me a bit with the setup here, I was confused with the process 😄. All good now.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #7254 (dcb097a) into main (008320a) will decrease coverage by 26.97%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7254       +/-   ##
==========================================
- Coverage   36.51%   9.53%   -26.98%     
==========================================
  Files          21      18        -3     
  Lines        2287    1080     -1207     
==========================================
- Hits          835     103      -732     
+ Misses       1401     976      -425     
+ Partials       51       1       -50     
Flag Coverage Δ
components-gitpod-cli-app 9.53% <9.09%> (?)
components-ws-proxy-app ?
installer-raw-app ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/gitpod-cli/cmd/credential-helper.go 1.16% <0.00%> (ø)
components/gitpod-cli/cmd/git-track-command.go 8.00% <8.00%> (ø)
components/gitpod-cli/cmd/version.go 40.00% <40.00%> (ø)
installer/pkg/common/display.go
components/ws-proxy/pkg/proxy/routes.go
installer/pkg/components/ws-manager/configmap.go
installer/pkg/common/render.go
...components/ws-manager/unpriviledged-rolebinding.go
components/ws-proxy/pkg/proxy/proxy.go
installer/pkg/common/objects.go
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645d9d3...dcb097a. Read the comment docs.

@filiptronicek filiptronicek changed the title track git command initial Track Git commands in analytics Dec 16, 2021
@filiptronicek
Copy link
Member

filiptronicek commented Dec 17, 2021

/werft run

👍 started the job as gitpod-build-track-git-commands.21

@filiptronicek
Copy link
Member

filiptronicek commented Dec 17, 2021

/werft run

👍 started the job as gitpod-build-track-git-commands.23

@filiptronicek filiptronicek marked this pull request as ready for review December 27, 2021 17:58
@roboquat roboquat added team: delivery Issue belongs to the self-hosted team and removed approved labels Jan 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yaml was changed and it might be harmful.

@roboquat
Copy link
Contributor

roboquat commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akosyakov, geropl

Associated issue: #6896

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@filiptronicek
Copy link
Member

Closing in favor of #7463

@akosyakov akosyakov deleted the track_git_commands branch January 8, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold release-note size/L team: delivery Issue belongs to the self-hosted team team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement analytics on git (git commit)
5 participants