Refactor and improve SSH gateway compatibility with some automatic client

[iQQBot]

Description

When use golang ssh client connect to workspace and execute some command, it return a error Err:wait: remote command exited without exit status or exit signal

This is because golang client send EOF flag too early

Related Issue(s)

Fixes #7771

How to test

Release Notes

NONE

Documentation

[codecov]

Codecov Report

Merging #7772 (20994db) into cw/fix-4779 (87ca302) will not change coverage.
The diff coverage is n/a.

❗ Current head 20994db differs from pull request most recent head e66e66d. Consider uploading reports for the commit e66e66d to get more accurate results

@@             Coverage Diff              @@
##           cw/fix-4779    #7772   +/-   ##
============================================
  Coverage        28.54%   28.54%           
============================================
  Files               39       39           
  Lines             3293     3293           
============================================
  Hits               940      940           
  Misses            2301     2301           
  Partials            52       52           

Flag	Coverage Δ
components-gitpod-cli-app	10.28% <ø> (ø)
components-ws-proxy-app	68.32% <ø> (ø)
installer-raw-app	5.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87ca302...e66e66d. Read the comment docs.

[iQQBot]

/werft run

👍 started the job as gitpod-build-pd-ssh-gateway-fix.12

[akosyakov]

How does one test that it does not break something else? Are there ways to add unit tests or something? Please fill in How to test section.

[iQQBot]

@akosyakov
I currently use a manual approach to testing, adding a lot of logs in key locations to verify that expectations are met, and there is no good way to unit test due to the large coupling with Gitpod internal

[iQQBot]

/werft run with-clean-deployment

👍 started the job as gitpod-build-pd-ssh-gateway-fix.17

[akosyakov]

I currently use a manual approach to testing, adding a lot of logs in key locations to verify that expectations are met, and there is no good way to unit test due to the large coupling with Gitpod internal

Please write down manual tests. In long term can we mock Gitpod internals and write tests against them to focus on SSH bits? I don't see how we can review and be sure about quality about one or another way of testing it.

[csweichel]

Please write down manual tests. In long term can we mock Gitpod internals and write tests against them to focus on SSH bits? I don't see how we can review and be sure about quality about one or another way of testing it.

💯 agreed. We can mock the info provider within ws-proxy and start SSH server using golang's ssh package akin to httptest

[csweichel]

@iQQBot as @akosyakov pointed out, I'd also appreciate some detail in the "How to test" section. I'd go through those tests then. Code-wise the changes look good - thank you for fixing the blunders in my original changeset (lesson learned: don't get cocky and don't rush code).

[csweichel]

/werft run with-clean-slate-deployment

👍 started the job as gitpod-build-pd-ssh-gateway-fix.22

[csweichel]

I ran the code outlined in #7771: it worked when run against this branch, it fails when run against production. I reckon that for now we're good. Considering the time-sensitive manner of this change, let's merge it.

@iQQBot Please, for all future PRs do fill in the "How to test" section - if it's manual tests that's fine, but others need to know how to test the PR.

/lgtm

[roboquat]

LGTM label has been added.

Git tree hash: 282b72230d97a63deb90e91f901f91c50b950446

[roboquat]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csweichel

Associated issue: #7771

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [csweichel]
• components/ws-proxy/OWNERS [csweichel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[iQQBot]

@csweichel Thanks for review, I will update "How to test" section later