Revert "Ship env vars as one-time secret" #8082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roboquat
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
jankeromnes
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Looks good, thanks.
Revert is because of env var breakage in prod: #7923 (comment)
mustard-mh
approved these changes
Feb 8, 2022
felladrin
approved these changes
Feb 8, 2022
akosyakov
approved these changes
Feb 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #8082 +/- ##
=========================================
- Coverage 12.01% 8.04% -3.97%
=========================================
Files 20 31 +11
Lines 1190 2212 +1022
=========================================
+ Hits 143 178 +35
- Misses 1043 2031 +988
+ Partials 4 3 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7923
Due to a bug in the Env Var injection.