[KOTS]: add recommended preflights #8857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
changed the title
github-actions
bot
added
the
team: delivery
mrsimonemms
force-pushed
the
sje/kots-preflights
branch
from
3edd999 to
cc331c6
Compare
It's not in the |
Pothulapati
reviewed
Mar 21, 2022
|
@Pothulapati we do actually create PVCs for in cluster Docker registry and Minio |
mrsimonemms
force-pushed
the
sje/kots-preflights
branch
from
cc331c6 to
53d7dcc
Compare
mrsimonemms
commented
Mar 22, 2022
| @@ -84,8 +84,16 @@ spec: | |||
| message: There must be at least one node with the label "gitpod.io/workload_workspace_headless" and value "true" | |||
| - pass: | |||
| message: Node with label exists | |||
| - customResourceDefinition: | |||
There was a problem hiding this comment.
I moved this up so the memory/CPU checks are in the same section - seemed more logical that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is derived from #8840 and the initial work on the recommended items
Related Issue(s)
Fixes #8846 - memory check
Fixes #8856 - default storage class
How to test
Deploy via KOTS and run preflights
Release Notes
Documentation