Skip to content

[kots]: update the logo #9159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2022
Merged

[kots]: update the logo #9159

merged 1 commit into from
Apr 7, 2022

Conversation

mrsimonemms
Copy link
Contributor

@mrsimonemms mrsimonemms commented Apr 6, 2022 •
edited
Loading

Description

Improved logo

How to test

Check in KOTS.

Old

image

New

image

Release Notes

[kots]: update the logo

Documentation

@roboquat roboquat added size/S and removed size/XS labels Apr 6, 2022
@mrsimonemms
Copy link
Contributor Author

/hold so @JohannesLandgraf and @chrifro can approve this from a design point of view

@mrsimonemms mrsimonemms marked this pull request as ready for review April 6, 2022 19:55
@mrsimonemms mrsimonemms requested a review from a team April 6, 2022 19:55
@mrsimonemms mrsimonemms changed the title WIP: [kots]: update the logo [kots]: update the logo Apr 6, 2022
@github-actions github-actions bot added the team: delivery Issue belongs to the self-hosted team label Apr 6, 2022
@mrsimonemms
Copy link
Contributor Author

/werft run publish-to-kots=true

@mrsimonemms
Copy link
Contributor Author

/werft run publish-to-kots=true

@mrsimonemms
Copy link
Contributor Author

@corneliusludmann Realised that the image wasn't being generated by the Weft job - it is now

gtsiolis
gtsiolis previously approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the screenshots this looks like an improvement. I'd only make sure this is using double width and height to support high density displays or the suggested and maximum dimensions required from the KOTS configuration. ✔️

I could be missing something but this is about customizing the application icon, right?

For logos to look best in the admin console, use a PNG or JPG that is square, at least 250x250 pixels, and exported at 2x.

In case you need it, here's a 250x250 logo exported in 2x.

Thanks @mrsimonemms for making this change! ✨

@mrsimonemms
Copy link
Contributor Author

Thanks @gtsiolis. Yes, it is for that (I think this is a new page in their docs, so well done on finding it).

I'll update the PR with your 2x image

@mrsimonemms mrsimonemms dismissed stale reviews from gtsiolis and corneliusludmann via a4b884c April 7, 2022 12:08
@mrsimonemms
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 2daeff1 into main Apr 7, 2022
@roboquat roboquat deleted the sje/kots-logo branch April 7, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corneliusludmann corneliusludmann corneliusludmann approved these changes

@gtsiolis gtsiolis Awaiting requested review from gtsiolis

Assignees
No one assigned
Labels
release-note size/S team: delivery Issue belongs to the self-hosted team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrsimonemms @gtsiolis @corneliusludmann @roboquat