Skip to content

[ws-daemon] Git configure safe.directory #9279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2022
Merged

[ws-daemon] Git configure safe.directory #9279

merged 2 commits into from
Apr 13, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 13, 2022 •
edited
Loading

Description

The last git version, v2.34.2 introduced a breaking change, requiring the configuration safe.directory.
Without this setting, git status returns an error:

git status --porcelain=v2 --branch -uall failed (exit status 128): fatal: unsafe repository ('XXXXXX' is owned by someone else)
To add an exception for this directory, call:

git config --global --add safe.directory XXXXXX

Release Notes

NONE

@aledbf aledbf force-pushed the aledbf/pin branch 2 times, most recently from 12d891a to c3f0d53 Compare April 13, 2022 04:22
@aledbf aledbf changed the title [ws-daemon] Pin git version [ws-daemon] Git configure safe.directory Apr 13, 2022
@aledbf aledbf marked this pull request as ready for review April 13, 2022 06:14
@aledbf aledbf requested a review from a team April 13, 2022 06:14
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 13, 2022
@aledbf
Copy link
Member Author

aledbf commented Apr 13, 2022

/hold

geropl
geropl reviewed Apr 13, 2022
View reviewed changes
@roboquat roboquat added size/XS and removed size/S labels Apr 13, 2022
csweichel
csweichel approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you.

@csweichel
Copy link
Contributor

/hold cancel

@roboquat roboquat merged commit 3edaa62 into main Apr 13, 2022
@roboquat roboquat deleted the aledbf/pin branch April 13, 2022 07:50
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Apr 13, 2022
@roboquat roboquat added the deployed Change is completely running in production label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl left review comments

@csweichel csweichel csweichel approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @csweichel @geropl @roboquat