Skip to content

Fix validation of user env vars #9460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2022
Merged

Fix validation of user env vars #9460

merged 3 commits into from
Apr 22, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Apr 21, 2022 •
edited
Loading

Description

This PR does 3 things:

  • fixes env var validation in the dashboard by enforcing are not starting with a number
  • extracts the validation into protocol
  • uses the same validation in server on setEnvVar

Related Issue(s)

Fixes #8950

How to test

Release Notes

fix and improve validation of user environment variables

Documentation

@geropl geropl changed the title Gpl/8950 envs Fix validation of user env vars Apr 21, 2022
@geropl
Copy link
Member Author

geropl commented Apr 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-clean-slate-deployment=true

👍 started the job as gitpod-build-gpl-8950-envs.3

@geropl
Copy link
Member Author

geropl commented Apr 22, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run with-vm=true

👍 started the job as gitpod-build-gpl-8950-envs.4

@geropl geropl marked this pull request as ready for review April 22, 2022 10:02
@geropl geropl requested a review from a team April 22, 2022 10:02
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 22, 2022
@roboquat roboquat merged commit d16776c into main Apr 22, 2022
@roboquat roboquat deleted the gpl/8950-envs branch April 22, 2022 10:16
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@andrew-farries andrew-farries andrew-farries approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitpod dashboard settings allows passing numbers as keys for environment variable
3 participants
@geropl @andrew-farries @roboquat