Skip to content

[server] Optimization: Map GitHub API repositories during pagination, not after #9462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2022
Merged

[server] Optimization: Map GitHub API repositories during pagination, not after #9462

merged 1 commit into from
Apr 21, 2022

Conversation

jankeromnes
Copy link
Contributor

Description

Follow-up to #9231: Map GitHub API repositories during pagination, not after.

Related Issue(s)

Fixes #9461

How to test

  1. Without adding a GitHub App, you should still be able to add Projects and run Prebuilds

Release Notes

[server] Optimization: Map GitHub API repositories during pagination, not after

Documentation

@jankeromnes jankeromnes requested a review from a team April 21, 2022 14:27
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 21, 2022
geropl
geropl approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@roboquat roboquat merged commit 3e24dc4 into main Apr 21, 2022
@roboquat roboquat deleted the jx/paginate-map branch April 21, 2022 14:50
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimization: Map GitHub API repositories during pagination, not after
3 participants
@jankeromnes @geropl @roboquat