fix(comment): allow new lines in comments on Android #207

lex111 · 2017-08-06T10:59:46Z

Fixes #206.

Need to check on iOS. There I understand, there was no such problem?

housseindjirdeh · 2017-08-06T15:42:07Z

Nice thank you! Will test this in a bit - will try and solve the issue happening on iOS myself as well 💃

lex111 · 2017-08-09T03:39:23Z

@housseindjirdeh what's new? Did you manage to test?

lex111 · 2017-08-09T03:41:17Z

src/components/comment-input.component.js

-  handleSubmit = (body: string): void => {
-    this.props.onSubmitEditing(body);
+  handleSubmitEditing = (body: string): void => {
+    if (Platform.OS === 'android') {


@housseindjirdeh If there is this bug on iOS, can this condition be removed? It is necessary to check on iOS with these changes, and then you can remove this condition, and check without it.

You can remove the condition, np with iOS

Then new lines will be added to iOS, did you check?

Yes I tested it without the condition, new lines are added but it still "a bug" when I post the comment (nothing is posted)

housseindjirdeh · 2017-08-10T00:06:30Z

My apologies, my week has been swamped and I haven't had the chance to test it :( If not today then hopefully tomorrow and I'll let you know. The thing with iOS is that it's just the return key that's causing to post and I feel like there should be a prop or something similar to do newline instead. 🤔

lex111 · 2017-08-10T03:09:13Z

@housseindjirdeh so by pressing the return key, a new line should be inserted? I thought the matter in the onSubmitEditing handler, because it was sending a message, and now it happens in the onSubmit handler. Perhaps this will help for iOS?

lex111 · 2017-08-10T03:10:07Z

src/issue/screens/issue.screen.js

@@ -301,7 +301,7 @@ class Issue extends Component {
              }
              issueLocked={issue.locked}
              language={language}
-              onSubmitEditing={this.postComment}


Now you can only set the onSubmit handler. The onSubmitEditing handler as I understand it is necessary to do some actions before sending.

Antoine38660 · 2017-08-12T19:14:25Z

src/components/comment-input.component.js

@@ -113,12 +120,12 @@ export class CommentInput extends Component {
                  : translate('issue.main.commentInput', language)
              }
              multiline
-              blurOnSubmit
+              blurOnSubmit={false}
              onChangeText={text => this.setState({ text })}
              onContentSizeChange={event =>
                this.setState({ height: event.nativeEvent.contentSize.height })}
              onSubmitEditing={event =>


According to the doc the onSubmitEditing is useless

Yes, but even if it is removed (or false), the problem remains. As I wrote, this is due to non-standard keyboards (on Android at least). Therefore, need to add an new line. I do not know how things are on iOS? Maybe there is enough to remove blurOnSubmit.

I just tried to post a comment with new line from the iOS simulator and nothing was posted...

Rather, it's because of my other changes, I changed the handlers (onSubmit, onSubmitEditing)? It would be cool to solve this on iOS, because everything is good on Android.

Ok, so let me try to fix this one for iOS :)

What kind of handler is needed to send?

Idk, can you post a comment from Android (with these changes)?

Yes, it's sent ... and wait .. After all, we have a comment sent only by the "Post" button, just there is a send handler.

I think it's sufficient :)

I do not understand why on iOS does not work? Do I need to remove the condition?

Antoine38660 · 2017-08-14T18:26:10Z

This is a test sent from iOS

With new lines.

UPD: @lex111 no problem with iOS dude ❤️ ❤️

lex111 · 2017-08-15T03:10:07Z

@Antoine38660 It is perfectly! It turns out we can merge?

Antoine38660

Of course yes :D

housseindjirdeh

Thanks a million @lex111, and thanks for testing this beauty @Antoine38660 🎉

* docs(README.md): add translation instruction (gitpoint#255) * chore(commit): Make the repo Commitizen-friendly (gitpoint#240) * chore(commit): Make the repo Commitizen-friendly * docs(contributors): change my profile url * docs(CONTRIBUTING.md): add information about Commitizen * docs(CONTRIBUTING.md): move translations snippet * docs(CONTRIBUTING.md): update commitzen snipper grammar * fix(comment-input): add new lines when writing issue comments on Android (gitpoint#207) * feat(repo): add label to show watch status (gitpoint#227) * Added react-native-cli to avoid onboarding issues in the future * Pull down to refresh implemented in profile page * Pull down to refresh implemented in Repository page. Closes gitpoint#103. * Fixed some merge issues * Fixing some more merging issues * Forgot to add myself as a contributor. * Fetching user data and fetching repository data have been moved into their own functions. * Fixed some merge issues. * Renamed the function that fetches the information to be a bit more descriptive * Again, fixing my own merge issues. Doing it here with code highlight and VSCode yelling at me is easier than on the Github editor. * Fixed some merge issues, _again_ * Added pull to refresh to the non auth profile screen. Other minor improv. * Fixing indentation inside of `<ScrollView />` * Removing extra newline * Adding a newline between our components and vendor components. * Added myself as a contributor. Code and Bug Reports * Valid NPM versions need to include three parts (x.y.z) * Removed the double ScrollView. Parallax can now take in refreshControl. Profile Screen, Repo, and Auth User screen have pull to refresh. * Pull down to refresh now in Issue/PR page (comment list) * Fixed some merging issues and yarn lockfile * Organizations are now refreshable * Better behavior on the AuthUser pull to refresh * Even better experience when refreshing AuthProfile. Now we have a flag when we _have_ a profile * Refreshing on Issues (specifically) works again * Used '!!' instead of '|| false' as per suggestion Temporal fix, I still want to figure out why isPendingComments and isPendingIssue are undefined. * Add a (watching) label that shows when a user is watching a repo already. * Fixed to look like gitpoint/master * feat(repository): fixed location of Watchers label * Minor code change to keep consistent with the style of the rest of the repo * docs: improve word choice (gitpoint#244) * Improved CONTRIBUTING.md * Improved contributing.md * docs(README.md): add contributor * fix(repo): Show repo prefix for search repo result (gitpoint#254) * fix(repo): hide issues section in forked repo (gitpoint#257)

fix(comment-input): add new lines when writing issue comments on Android

d1668b4

lex111 added the ready for review label Aug 6, 2017

lex111 mentioned this pull request Aug 6, 2017

Cannot add new lines when writing issue comments #206

Closed

lex111 commented Aug 9, 2017

View reviewed changes

lex111 commented Aug 10, 2017

View reviewed changes

andrewda changed the title ~~Fix adding of new lines when writing issue comments on Android~~ fix(comment): allow new lines in comments on Android Aug 11, 2017

lex111 mentioned this pull request Aug 12, 2017

fix(new-issue): various submit new issue improvement #243

Merged

2 tasks

Antoine38660 reviewed Aug 12, 2017

View reviewed changes

lex111 added 🏗️ work in progress and removed ready for review labels Aug 14, 2017

andrewda approved these changes Aug 15, 2017

View reviewed changes

Antoine38660 added ready for review and removed 🏗️ work in progress labels Aug 15, 2017

Antoine38660 approved these changes Aug 15, 2017

View reviewed changes

housseindjirdeh approved these changes Aug 16, 2017

View reviewed changes

housseindjirdeh merged commit a961bbe into gitpoint:master Aug 16, 2017

Antoine38660 mentioned this pull request Sep 6, 2017

Allow line breaks for issue comments #287

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(comment): allow new lines in comments on Android #207

fix(comment): allow new lines in comments on Android #207

lex111 commented Aug 6, 2017

housseindjirdeh commented Aug 6, 2017

lex111 commented Aug 9, 2017

lex111 Aug 9, 2017 •

edited

Loading

Antoine38660 Aug 12, 2017

lex111 Aug 13, 2017

Antoine38660 Aug 13, 2017 •

edited

Loading

housseindjirdeh commented Aug 10, 2017

lex111 commented Aug 10, 2017

lex111 Aug 10, 2017 •

edited

Loading

Antoine38660 Aug 12, 2017

lex111 Aug 12, 2017

Antoine38660 Aug 12, 2017 •

edited

Loading

lex111 Aug 12, 2017 •

edited

Loading

Antoine38660 Aug 12, 2017

lex111 Aug 14, 2017

Antoine38660 Aug 14, 2017

lex111 Aug 14, 2017

Antoine38660 Aug 14, 2017

lex111 Aug 14, 2017 •

edited

Loading

Antoine38660 commented Aug 14, 2017 •

edited

Loading

lex111 commented Aug 15, 2017

Antoine38660 left a comment

housseindjirdeh left a comment

fix(comment): allow new lines in comments on Android #207

fix(comment): allow new lines in comments on Android #207

Conversation

lex111 commented Aug 6, 2017

housseindjirdeh commented Aug 6, 2017

lex111 commented Aug 9, 2017

lex111 Aug 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antoine38660 Aug 13, 2017 • edited Loading

Choose a reason for hiding this comment

housseindjirdeh commented Aug 10, 2017

lex111 commented Aug 10, 2017

lex111 Aug 10, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antoine38660 Aug 12, 2017 • edited Loading

Choose a reason for hiding this comment

lex111 Aug 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lex111 Aug 14, 2017 • edited Loading

Choose a reason for hiding this comment

Antoine38660 commented Aug 14, 2017 • edited Loading

lex111 commented Aug 15, 2017

Antoine38660 left a comment

Choose a reason for hiding this comment

housseindjirdeh left a comment

Choose a reason for hiding this comment

lex111 Aug 9, 2017 •

edited

Loading

Antoine38660 Aug 13, 2017 •

edited

Loading

lex111 Aug 10, 2017 •

edited

Loading

Antoine38660 Aug 12, 2017 •

edited

Loading

lex111 Aug 12, 2017 •

edited

Loading

lex111 Aug 14, 2017 •

edited

Loading

Antoine38660 commented Aug 14, 2017 •

edited

Loading