fix(new-issue): various submit new issue improvement #243

Antoine38660 · 2017-08-12T19:00:26Z

Also give ability to add new line in the issue body

lex111 · 2017-08-12T19:09:10Z

Also give ability to add new line in the issue body

Look #207 please, I did there for Android, but I need to look at iOS.

UPD: Can there be a fix if there is a PR for this?

housseindjirdeh · 2017-08-14T16:50:32Z

routes.js

@@ -135,6 +135,7 @@ const sharedRoutes = {

      return {
        title: isPR ? `Pull Request #${number}` : `Issue #${number}`,
+        headerLeft: navigation.state.params.headerLeft,


Although this would essentially solve hiding the header on the left, have you tried swiping the screen from the left side? That might still allow the user to navigate back which we wouldn't want.

Also see comment 2 about possibly simplifying this flow 🕺

You're right, I haven't tried to swipe left, and it still allow the user to navigate back...

(-> Comment 2)

housseindjirdeh · 2017-08-14T16:50:39Z

src/issue/screens/new-issue.screen.js

    const { issueTitle, issueComment } = this.state;

    return (
      <ViewContainer>
+        {isPendingSubmitting && <LoadingModal />}


housseindjirdeh · 2017-08-14T16:52:39Z

src/issue/screens/new-issue.screen.js

@@ -90,17 +92,19 @@ class NewIssue extends Component {
      ).then(issue => {
        navigation.navigate('Issue', {
          issue,
+          headerLeft: false,


Comment #2

So instead of passing a prop to hide the header, it might just be simpler to use navigation.reset to reset the current navigation stack instead of pushing another route on top. That way there shouldn't be a navigate back functionality at all and we wouldn't have to workaround trying to pass a manual prop to hide it.

Let me know what you think @Antoine38660 :)

I tried to use the reset function (defined in utils/method-helpers.js) but I had an error, something like:

'Issue' key is not defined, you should use Login, Main ...

I'll try now with navigation.reset directly 😃

Thanks for reviewed this!

With navigation.reset, we can't navigate back ✅
BUT the bottom menu item selected when we create the issue can no longer be used: It redirect back to the created issue instead of its normal behavior... 😞

Ah that error message is most likely because its only on the top Stack (see here) hence why it can't recognize the Issue screen 🤔

Glad to hear that just using .reset worked (somewhat) :P. The bottom menu item? Are you referring to the tab navigator?

Yes I was referring the tab navigator.

Here's a gif of the behavior:

When I go back to the "User" tab, I spam the "User" tab item but it doesn't redirect me to my profile screen....

AH snap, didn't think of that 🤔

So double tapping the a single tab navigator will take you back to the root of that stack because of this code here. However, using navigation.reset in this step will cause that to be the root of the stack which we don't really want.

This is a little tricker than I thought it would be 😂. There's an attribute that we should easily be able to extend to the issue screen to prevent swipe backs (react-navigation/react-navigation#1063 (comment)) but I don't want to always disable it for the screen.

Some thoughts:

Maybe we can use this attribute but connect to navigation params so that it's only false based on the param (which we can set only on this navigate step to Issue Screen? That way with this + headerLeft: null would not allow the user to go back. Sounds easier said than done 🤔

Maybe we can leverage a modal screen here instead? Haven't tried to load a modal with React Navigation yet but maybe it might be worthwhile to try here?

Either way, happy to merge this in if you would rather we deal with this as part of a separate bug ticket 🎉

I can try to implement the 1) (with gesturesEnabled: false + headerLeft: null) 😄

But I don't understand the second option with modal :(

housseindjirdeh · 2017-08-14T16:52:48Z

src/issue/screens/new-issue.screen.js

@@ -140,7 +144,6 @@ class NewIssue extends Component {
            <TextInput
              underlineColorAndroid={'transparent'}
              placeholder={translate('issue.newIssue.writeAComment', language)}
-              blurOnSubmit


…#236

Antoine38660 · 2017-08-17T14:58:59Z

It works like a charm mate 😃

I disabled swipe back with gesturesEnabled: false and hide the header left btn with headerLeft: null on the Issue screen only if we just submitted the issue. 👍

housseindjirdeh

Yaaas thank you so much my friend @Antoine38660 🙌

Antoine38660 added the 🏗️ work in progress label Aug 12, 2017

Antoine38660 added ready for review and removed 🏗️ work in progress labels Aug 12, 2017

andrewda changed the title ~~fix(submit new issue): various submit new issue improvement~~ fix(new-issue): various submit new issue improvement Aug 13, 2017

housseindjirdeh requested changes Aug 14, 2017

View reviewed changes

Antoine38660 added 2 commits August 14, 2017 19:36

fix(issue): hide back btn after submitting a new issue - fix gitpoint…

dc9941c

…#236

fix(issue): ability to add newline in issue body

8178d32

Antoine38660 force-pushed the improvment/submit-issue-improvement branch from cdc0f68 to 33efa6d Compare August 14, 2017 17:36

Antoine38660 added 2 commits August 17, 2017 16:42

fix(submit newissue): show a loading modal after submiting a new issue

b265130

fix: disable swipe back AND header leftbtn after when submit an issue

89fd08f

Antoine38660 force-pushed the improvment/submit-issue-improvement branch from 33efa6d to 89fd08f Compare August 17, 2017 14:52

housseindjirdeh approved these changes Aug 20, 2017

View reviewed changes

housseindjirdeh merged commit 6863271 into gitpoint:master Aug 20, 2017

Antoine38660 mentioned this pull request Sep 6, 2017

Back button after creating and issue should not go back to “create issue” #293

Closed

Antoine38660 mentioned this pull request Oct 6, 2017

New issue screen not closing after submit #432

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(new-issue): various submit new issue improvement #243

fix(new-issue): various submit new issue improvement #243

Antoine38660 commented Aug 12, 2017 •

edited

Loading

lex111 commented Aug 12, 2017 •

edited

Loading

housseindjirdeh Aug 14, 2017

Antoine38660 Aug 14, 2017

housseindjirdeh Aug 14, 2017

housseindjirdeh Aug 14, 2017

Antoine38660 Aug 14, 2017 •

edited

Loading

Antoine38660 Aug 15, 2017 •

edited

Loading

housseindjirdeh Aug 16, 2017

Antoine38660 Aug 16, 2017

housseindjirdeh Aug 16, 2017

Antoine38660 Aug 17, 2017 •

edited

Loading

housseindjirdeh Aug 14, 2017

Antoine38660 commented Aug 17, 2017

housseindjirdeh left a comment

fix(new-issue): various submit new issue improvement #243

fix(new-issue): various submit new issue improvement #243

Conversation

Antoine38660 commented Aug 12, 2017 • edited Loading

lex111 commented Aug 12, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antoine38660 Aug 14, 2017 • edited Loading

Choose a reason for hiding this comment

Antoine38660 Aug 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antoine38660 Aug 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Antoine38660 commented Aug 17, 2017

housseindjirdeh left a comment

Choose a reason for hiding this comment

Antoine38660 commented Aug 12, 2017 •

edited

Loading

lex111 commented Aug 12, 2017 •

edited

Loading

Antoine38660 Aug 14, 2017 •

edited

Loading

Antoine38660 Aug 15, 2017 •

edited

Loading

Antoine38660 Aug 17, 2017 •

edited

Loading