fix(events): Fix wrong wording for commented on pull request #262
Conversation
|
Hmm, for sure, here is a similar situation as the IssueCommentEvent. @machour do you think it can then refactor the code of this event, as it is done in |
|
I didn't see that wording yet, so I'm not sure. But I think it's superfluous for now, as I don't think the current translation system is okay in general. I'll open a new ticket with all my thoughts on the subject and a much cleaner implementation proposal where |
|
Specifically about these cases - this is an exception, if GitHub returned the correct action, would not have to do a substitution. It would be interesting to know about the cleaner implementation, well, let's discuss this in the new issue. |
| @@ -155,7 +155,7 @@ class Events extends Component { | |||
| 'auth.events.pullRequestReviewCommentEvent', | |||
| language, | |||
| { | |||
| action: translate(`auth.events.actions.${action}`, language), | |||
| action: translate('auth.events.actions.commented', language), | |||
There was a problem hiding this comment.
I'm assuming it's incorrect because passing in created is why the wrong message shows right? Perfectly okay with having .commented specifically here in that case
|
Thanks for this homie 👍 |
Closes #261