Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): Hide tabbar when keyboard show #435

Merged
merged 1 commit into from
Oct 6, 2017
Merged

fix(android): Hide tabbar when keyboard show #435

merged 1 commit into from
Oct 6, 2017

Conversation

lex111
Copy link
Member

@lex111 lex111 commented Oct 6, 2017

This problem is only on Android, looked at the iOS-simulator, the tabbar is hidden there, but on Android no.

housseindjirdeh
housseindjirdeh approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you <3

@housseindjirdeh housseindjirdeh merged commit 8e49116 into master Oct 6, 2017
@lex111 lex111 deleted the android-hide-tab-bar branch October 6, 2017 21:55
@lex111
Copy link
Member Author

lex111 commented Oct 7, 2017

@housseindjirdeh the app needs to be updated on Google Play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@housseindjirdeh housseindjirdeh housseindjirdeh approved these changes

Assignees
No one assigned
Labels
🐛 bug ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lex111 @housseindjirdeh