Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(md): Play nice with anchors #465

Merged
merged 1 commit into from
Oct 11, 2017
Merged

fix(md): Play nice with anchors #465

merged 1 commit into from
Oct 11, 2017

Conversation

machour
Copy link
Member

@machour machour commented Oct 10, 2017

Fix a new markdown bug, this time with anchors.
Also got rid of node.children[0].data in favor of defaultRenderer(node.children, node), so that links containing more than a single text child are well rendered.

Like this one for example with the commit hash at the end: machour/git-point-playground@4872692

Fixes #462

@chinesedfan
Copy link
Member

@machour Does this one really solve #462, or partially?

Copy link
Member

@housseindjirdeh housseindjirdeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you homie 👍

@housseindjirdeh housseindjirdeh merged commit 1fb5165 into gitpoint:master Oct 11, 2017
@machour machour deleted the markdown-anchors branch October 12, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants