feat(translation): add mandarin Chinese translation #583

pallymore · 2017-10-26T02:53:08Z

part of #439

Hello,

I know this is not in the languages requested.
I took a stab and finished the Chinese translation anyways since I'm interested in this project (have been looking for a good github client for a very long time)

Feel free to make any comments, or suggestions (from other Mandarin speakers)

There is no official Mandarin support for Github - I used the official translation guide for git instead.
https://github.com/git/git/blob/master/po/zh_CN.po

coveralls · 2017-10-26T02:59:16Z

Coverage increased (+0.04%) to 34.548% when pulling 0d9e9cc on pallymore:mandarin-support into 6567aa3 on gitpoint:master.

andrewda · 2017-10-26T06:30:13Z

src/locale/index.js

@@ -1,6 +1,6 @@
 import I18n from 'react-native-i18n';
 import { common } from 'config';
-import { en, fr, nl, pt, ptBr, tr, ru, eo, gl, pl, de, es } from './languages';
+import { en, fr, nl, pt, ptBr, tr, ru, eo, gl, pl, de, es, zhCN } from './languages';


Use a lowercase "n" => zhCn.

andrewda · 2017-10-26T06:30:28Z

src/locale/languages/zh-cn.js

+// Hash: 01ae4880b9b4296907d680e9b909713c36c42491
+// Link: https://github.com/gitpoint/git-point/pull/260
+
+export const zhCN = {


Lowercase "n"

andrewda · 2017-10-26T06:34:18Z

Also, run prettier to format your code (it should run when you git commit unless your environment is a bit funky). Running prettier will fix the travis build.

pallymore · 2017-10-26T12:56:53Z

hello @andrewda , thanks for your review.
I fixed zhCN to zhCn
and did npm run prettier
although it generated some changes in other files as well :/
i committed them anyways assuming you want all code to be prettified.

coveralls · 2017-10-26T13:01:53Z

Coverage increased (+0.04%) to 34.548% when pulling 16cda13 on pallymore:mandarin-support into 6567aa3 on gitpoint:master.

andrewda

👍

chinesedfan

@pallymore Thanks for your patient translations. I didn't do this before, because I think professional terms will become very funny once translated into Chinese. 🤣

chinesedfan · 2017-10-26T14:16:40Z

src/locale/languages/zh-cn.js

+// Hash: 01ae4880b9b4296907d680e9b909713c36c42491
+// Link: https://github.com/gitpoint/git-point/pull/260
+
+export const zhCn = {


@andrewda Please forgive me. I have never seen this kind of abbreviation. Normal usages are zhCN/zhTW/enUS and so on. What do you think? Maybe we should revert it as zhCN and update ptBr as ptBR.

Yea, I think zhCN/ptBR is more common as CN/BR/US are country abbreviations. zhCn or enUs looks weird to me. @andrewda ?

chinesedfan · 2017-10-26T14:18:11Z

src/locale/languages/zh-cn.js

+      notificationsTitle: '通知设定',
+      notificationsMessage: '查看并设定你所有未读和参与的通知',
+      reposTitle: '仓库和用户',
+      reposMessage: '便捷的获取仓库、用户、以及组织的信息',


便捷地获取仓库、用户以及组织的信息

chinesedfan · 2017-10-26T14:19:54Z

src/locale/languages/zh-cn.js

+      reposTitle: '仓库和用户',
+      reposMessage: '便捷的获取仓库、用户、以及组织的信息',
+      issuesTitle: '问题和合并请求',
+      issuesMessage: '查看问题、参与讨论、以及处理合并请求',


查看问题、参与讨论以及处理合并请求

chinesedfan · 2017-10-26T14:20:51Z

src/locale/languages/zh-cn.js

+      pullRequestReviewCommentEvent: '{{action}} 了合并请求',
+      pullRequestReviewEditedEvent: '{{action}} 他们对合并请求的审查',
+      pullRequestReviewDeletedEvent: '{{action}} 他们对合并请求的审查',
+      releaseEvent: '{{action}} 发行',


chinesedfan · 2017-10-26T14:25:22Z

src/locale/languages/zh-cn.js

+    privacyPolicy: {
+      title: '隐私条款',
+      effectiveDate: '最近更新: 2017年7月15日',
+      introduction: '我们很高兴您选择使用GitPoint。您可以在本隐私条款中看到我们如何使用，以及不使用，我们用户数据的信息。',


我们很高兴您选择使用GitPoint。您可以在本隐私条款中看到我们使用哪些和不使用哪些用户数据。

chinesedfan · 2017-10-26T14:37:24Z

src/locale/languages/zh-cn.js

+      userData1:
+        '我们不使用您任何GitHub的信息。在使用GitHub登录后，用户的OAuth令牌只保存在客户端。我们无法获取令牌信息。我们用户查看或者保存用户的访问令牌。',
+      userData2:
+        '这意味着，我们不可能查看、使用、或者分享用户的GitHub数据。即便隐私数据可以被查看，我们也不会查看或者保存它。如果它被意外的保存，我们会使用安全抹除的方案立刻删除它。再次重申，我们设计使用的登录方法可以保证这种情形不会发生。',


这意味着，我们不可能查看、使用，或者分享用户的GitHub数据。即便隐私数据可以被访问，我们也不会查看或者保存它。如果它被意外地保存，我们会立即使用安全的抹除方案删除它。再次重申，我们已经特别地建立了授权机制以保证这种情形不会发生。

chinesedfan · 2017-10-26T14:39:18Z

src/locale/languages/zh-cn.js

+      analyticsInfoTitle: '分析数据',
+      analyticsInfo1:
+        '目前我们使用Google Analytics和iTunes App Analytics来帮助我们分析GitPoint的流量和使用趋势。这些工具从您的设备上收集包含设备类型、版本、区域、来源等信息。这些信息并无法被用来识别单个用户或者获取任何个人信息。',
+      analyticsInfo2: '如果我们使用第三方平台来收集追溯栈、错误报告、或者其他分析用信息，我们将保证用户的信息均为匿名并且加密。',


如果我们使用第三方平台来收集追溯栈、错误报告，或者更多的分析信息，我们将保证用户的信息均为匿名并且加密。

chinesedfan · 2017-10-26T14:40:45Z

src/locale/languages/zh-cn.js

+      analyticsInfo2: '如果我们使用第三方平台来收集追溯栈、错误报告、或者其他分析用信息，我们将保证用户的信息均为匿名并且加密。',
+      openSourceTitle: '开源',
+      openSource1: 'GitPoint是开源软件，所有对本软件的历史贡献信息都会一直向外界公开。',
+      openSource2: '向本App提交的每次代码贡献都会经过我们的审查以防止任何人注入任何的恶意代码。',


每次向本App提交的代码贡献都会经过我们的审查以防止任何人注入任何形式的恶意代码。

chinesedfan · 2017-10-26T14:41:58Z

src/locale/languages/zh-cn.js

+      openSource2: '向本App提交的每次代码贡献都会经过我们的审查以防止任何人注入任何的恶意代码。',
+      contactTitle: '联系方式',
+      contact1: '感谢阅读我们的隐私条款。我们希望您如同我们享受开发GitPoint的过程一般享受使用它！',
+      contact2: '如果您对本条款或GitPoint有任何问题，请在我们的仓库页面提交：',


如果您对本条款或GitPoint有任何问题，请提交问题到

chinesedfan · 2017-10-26T14:46:48Z

src/locale/languages/zh-cn.js

+    followers: {
+      title: '粉丝',
+      text: '粉丝',
+      followsYou: '你已关注',


建议统一用“您”。或者除了较正式的公告性质的隐私声明，别的普通界面处统一用“你”。

pallymore · 2017-10-26T16:18:39Z

Thanks for the thorough review. @chinesedfan

Yes, I wasn't sure if I should leave the GitHub/Git jargons as they are since they can be weird once translated to Chinese. I guess we could gather some feedback from the users to see if we should only translate common UI/Message texts.

coveralls · 2017-10-26T16:20:44Z

Coverage increased (+0.04%) to 34.548% when pulling f1f5e51 on pallymore:mandarin-support into 6567aa3 on gitpoint:master.

coveralls · 2017-10-26T16:20:48Z

Coverage increased (+0.04%) to 34.548% when pulling f1f5e51 on pallymore:mandarin-support into 6567aa3 on gitpoint:master.

coveralls · 2017-11-04T12:42:48Z

Coverage increased (+0.04%) to 39.398% when pulling 0edf9d6 on pallymore:mandarin-support into e5c0291 on gitpoint:master.

adds chinese(mandarin-simplified) translation

0d9e9cc

lex111 requested a review from chinesedfan October 26, 2017 05:28

andrewda requested changes Oct 26, 2017

View reviewed changes

andrewda changed the title ~~adds Chinese(mandarin-simplified) translation~~ translation(mandarin): add mandarin Chinese translation Oct 26, 2017

fixes zhCN to zhCn, and ran prettier

16cda13

andrewda changed the title ~~translation(mandarin): add mandarin Chinese translation~~ feat(translation): add mandarin Chinese translation Oct 26, 2017

andrewda approved these changes Oct 26, 2017

View reviewed changes

chinesedfan requested changes Oct 26, 2017

View reviewed changes

pallymore added 2 commits October 26, 2017 12:12

updates translations based on @chinesedfan's comments

a785a30

updates ptBr to ptBR and zhCn to zhCN

f1f5e51

chinesedfan approved these changes Oct 27, 2017

View reviewed changes

chinesedfan and others added 2 commits November 4, 2017 11:28

Merge branch 'master' into mandarin-support

ab36da4

Merge branch 'master' into mandarin-support

0edf9d6

chinesedfan merged commit b3e182f into gitpoint:master Nov 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(translation): add mandarin Chinese translation #583

feat(translation): add mandarin Chinese translation #583

pallymore commented Oct 26, 2017

coveralls commented Oct 26, 2017

andrewda Oct 26, 2017

andrewda Oct 26, 2017

andrewda commented Oct 26, 2017

pallymore commented Oct 26, 2017

coveralls commented Oct 26, 2017

andrewda left a comment

chinesedfan left a comment

chinesedfan Oct 26, 2017

pallymore Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

chinesedfan Oct 26, 2017

pallymore commented Oct 26, 2017

coveralls commented Oct 26, 2017

coveralls commented Oct 26, 2017

coveralls commented Nov 4, 2017

feat(translation): add mandarin Chinese translation #583

feat(translation): add mandarin Chinese translation #583

Conversation

pallymore commented Oct 26, 2017

coveralls commented Oct 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewda commented Oct 26, 2017

pallymore commented Oct 26, 2017

coveralls commented Oct 26, 2017

andrewda left a comment

Choose a reason for hiding this comment

chinesedfan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pallymore commented Oct 26, 2017

coveralls commented Oct 26, 2017

coveralls commented Oct 26, 2017

coveralls commented Nov 4, 2017