Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setTranslucent and setBackgroundColor are Android only #653

Merged
merged 1 commit into from
Dec 5, 2017
Merged

fix: setTranslucent and setBackgroundColor are Android only #653

merged 1 commit into from
Dec 5, 2017

Conversation

machour
Copy link
Member

@machour machour commented Dec 4, 2017

Question Response
Version? master
Devices tested? iPhone 7
Bug fix? yes
New feature? no
Includes tests? no
All Tests pass? yes

Description

This PR silences the following warning on iOS by testing the platform OS:

2017-12-04 14:05:11.418 [warn][tid:com.facebook.react.JavaScript] `setTranslucent` is only available on Android
2017-12-04 14:05:11.418 [warn][tid:com.facebook.react.JavaScript] `setBackgroundColor` is only available on Android

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.937% when pulling 8c0c63d on machour:silence-status-bar into 2bc73fe on gitpoint:master.

chinesedfan
chinesedfan approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@chinesedfan chinesedfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machour You are expert of Android, haha!

@jouderianjr
Copy link
Member

@machour sorry for that 🙈 good catch I didn't saw that.

@chinesedfan chinesedfan merged commit 55abff8 into gitpoint:master Dec 5, 2017
@machour machour deleted the silence-status-bar branch December 5, 2017 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jouderianjr jouderianjr jouderianjr approved these changes

@chinesedfan chinesedfan chinesedfan approved these changes

@lex111 lex111 lex111 approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machour @coveralls @jouderianjr @chinesedfan @lex111