Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commit requires author to be Actor, not string #806

Closed
frafra opened this issue Nov 6, 2018 · 1 comment · Fixed by #841
Closed

commit requires author to be Actor, not string #806

frafra opened this issue Nov 6, 2018 · 1 comment · Fixed by #841
Labels
acknowledged help wanted
Milestone
v3.0.0 - Remove P...

Comments

@frafra
Copy link

frafra commented Nov 6, 2018

Documentation is wrong about the author parameter: it has to be an Actor, not a string.
@Byron
Copy link
Member

Byron commented Dec 22, 2018

Thanks for the note, quick PR would be welcome.

CptMikhailov added a commit to CptMikhailov/GitPython that referenced this issue Feb 13, 2019
@CptMikhailov
Update commit.py constructor docstring
d40aedb 
Fixes issue gitpython-developers#806: Commit requires author parameter to be of Actor type, not string.
CptMikhailov added a commit to CptMikhailov/GitPython that referenced this issue Feb 13, 2019
@CptMikhailov
Added name to authors
c7e2644 
Fixed issue gitpython-developers#806
@CptMikhailov CptMikhailov mentioned this issue Feb 13, 2019
Merged
Byron pushed a commit that referenced this issue Mar 15, 2019
@CptMikhailov @Byron
Update commit.py constructor docstring
881e315 
Fixes issue #806: Commit requires author parameter to be of Actor type, not string.
Byron pushed a commit that referenced this issue Mar 15, 2019
@CptMikhailov @Byron
Added name to authors
1f66e25 
Fixed issue #806
@Byron Byron added this to the v2.1.12 - Bugfixes milestone Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged help wanted
Milestone
v3.0.0 - Remove Python 2
Development

Successfully merging a pull request may close this issue.

Fix commit.py documentation CptMikhailov/GitPython
2 participants
@frafra @Byron