Skip to content

Fix ignored #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 22, 2023
Merged

Fix ignored #1545

merged 3 commits into from
Jan 22, 2023

Conversation

Lightborne
Copy link
Contributor

  • Add test to sanity-check basic behavior of ignored() method
  • Add test to verify GitCommandError is raised if git check-ignore returns any error code other than 1
  • Modify ignred() method to raise GitCommandError if git check-ignore returns any error code other than 1

@Lightborne Lightborne mentioned this pull request Jan 21, 2023
Closed
@Byron Byron added this to the v3.1.31 - Bugfixes milestone Jan 22, 2023
@Byron
Copy link
Member

Byron commented Jan 22, 2023

Great work, thanks so much! I love to finally have a test for that.

For a moment I thought this might be a breaking change, just to realize that the previous implementation was just a little too 'unconditional' and this PR implements the proper fix by raising an error when the error code does not indicate a lack of matches.

@Byron Byron merged commit cc92d51 into gitpython-developers:main Jan 22, 2023
@Lightborne
Copy link
Contributor Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v3.1.31 - Bugfixes
Development

Successfully merging this pull request may close these issues.
2 participants
@Lightborne @Byron