Fix RecursionError when iterating streams #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, I have a feeling that this issue was present for a long time already! Do you think Python 2 compatibility is still required? Support for it was dropped a while ago and if you agree it can be dropped entirely. |
|
I have no objection to dropping the |
eric-wieser
commented
Feb 12, 2023
Comment on lines
+704
to
+705
| next = __next__ | ||
|
|
There was a problem hiding this comment.
Feel free to commit through the github UI if you want to drop this Python2 compatibility layer entirely:
Suggested change
| next = __next__ |
Note that there may be some downstream code that relies on using next because __next__ was broken though!
There was a problem hiding this comment.
Ah, right. Oh well, let's be conservative then.
|
Great! Let's do that and the PR can be merged. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next(self)was previously just a recursive call that does nothing.This now implements
__next__using the actual implementation, and lets the python2-compatibilitynext()just wrap it.