Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_values() so it correctly loads section names #1555

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Fix get_values() so it correctly loads section names #1555

merged 2 commits into from
Feb 16, 2023

Commits on Jan 10, 2023

  1. get_values eagerly loads sections before return

    @kfreezen
    kfreezen committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    cfc613a View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Add test asserting that get_values works by itself 

    As described in #1534, this test will fail in main with a KeyError
about a missing section name even though the named sections do exist
within the config file.

This test will pass in the branch associated with #1535. This test
should keep the improved behavior healthy as the code evolves by
preventing future developers from removing the eager loading of
sections within get_values().
    @Codym48
    Codym48 committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    fc843d3 View commit details
    Browse the repository at this point in the history