Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_user_id: use EUID instead of getpass.getuser() to resolve users #1578

Closed
wants to merge 1 commit into from

Conversation

b4ldr
Copy link

@b4ldr b4ldr commented Apr 26, 2023

fixes #1577

@Byron
Copy link
Member

Byron commented Apr 26, 2023

No argument is made for why this should be preferred over the current implementation.

However, while checking what git does I noticed that it does also use getuid().

Thus there is nothing to fix, and changing it would be a breaking change as well which is another reason not to pursue this further. Thanks for your understanding.

@Byron Byron closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

git_user_id should returnt he EUID
2 participants