Skip to content

Conversation

ankostis
Copy link
Contributor

@ankostis ankostis commented Oct 1, 2016

  • 3 errors remain in all python versions (py27, py34, py35, conda35).
  • One set of errors fixed: div-by-zero on elapsed times - Appveyor must be quick.

+ On Windows, you cannot write onto a file held by another live
file-pointer (test_pack.py:#L204).
+ The TC fails later, on clean up (the usual).
@ankostis
Copy link
Contributor Author

@Byron any update on that?

@Byron
Copy link
Member

Byron commented Oct 23, 2016

Which action is expected of me ? Right now I am a bit lost, but happy to help/follow-up.

@ankostis
Copy link
Contributor Author

Merge, although 3 TCs still fail on Windows.
(have not push rights in smmp, maybe the the same for gitdb, have not checked).

@Byron
Copy link
Member

Byron commented Oct 23, 2016

Please recheck: I have fixed permissions for smmap, and for gitdb you do already have write permissions.

@ankostis ankostis merged commit fd2eba4 into gitpython-developers:master Oct 24, 2016
@ankostis ankostis deleted the appveyor branch October 24, 2016 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants