Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 2 compatibility shims #56

Merged
merged 10 commits into from
Feb 17, 2020
Merged

Remove Python 2 compatibility shims #56

merged 10 commits into from
Feb 17, 2020

Conversation

Harmon758
Copy link
Member

This PR removes and replaces Python 2 compatibility shims, since Python 2 support was dropped with c880f6b in 3.0.0:

  • Remove compat.memoryview and compat.PY3
  • Remove and replace compat.buffer and compat.to_bytes
  • Remove and replace compat.izip with zip, compat.MAXSIZE with sys.maxsize, compat.xrange with range
  • Remove and replace encoding.string_types and encoding.text_type with str
  • Remove and replace izip in TestPack

@Harmon758 Harmon758 requested a review from Byron February 16, 2020 14:32
@Harmon758 Harmon758 self-assigned this Feb 16, 2020
Byron
Byron approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely fantastic, thanks so much for your work!
I will be releasing this in a moment, and publish a new version of GitPython as well with adjusted requirements.

@Byron Byron merged commit 183d1bc into gitpython-developers:master Feb 17, 2020
@Harmon758 Harmon758 deleted the python-2-support-removal branch February 17, 2020 02:38
@danieldooley danieldooley mentioned this pull request Feb 18, 2020
Closed
@tadeu tadeu mentioned this pull request Feb 18, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees

@Harmon758 Harmon758

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Harmon758 @Byron