Skip to content

Fix exception causes all over the codebase #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2020
Merged

Fix exception causes all over the codebase #64

merged 1 commit into from
Jun 15, 2020

Conversation

cool-RR
Copy link
Contributor

@cool-RR cool-RR commented Jun 14, 2020

No description provided.

Byron
Byron approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

If you are interested, there is an authors file in GitPython that you are free to add yourself to. It's actually a bit of a misnomer, as it's for contributors as well.

@Byron Byron merged commit 112252c into gitpython-developers:master Jun 15, 2020
@cool-RR
Copy link
Contributor Author

cool-RR commented Jun 24, 2020

I just made a blog post about this change here: https://blog.ram.rachum.com/post/621791438475296768/improving-python-exception-chaining-with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cool-RR @Byron