Skip to content

Conversation

uniqueNullptr2
Copy link
Contributor

@uniqueNullptr2 uniqueNullptr2 commented Dec 19, 2021

This Pull Request fixes/closes #1047

It changes the following:
dis able the following buttons and functions in repos without any remote branches

  • push in status tab
  • pull in status tab
  • fetch in branches window of status tab

I followed the checklist:

  • I added unittests
  • I ran make check without errors -> shows error event fn too long but is unrelated to my changes
  • I tested the overall application
  • I added an appropriate item to the changelog -> not sure where

@uniqueNullptr2
Copy link
Contributor Author

After looking through the errors I notice 2 distinct errors happening.

most of the time clippy complains about the eventfunction being too long. Unlike I wrongly stated in the first message this seems to be related to me adding a few lines to that function which is already pretty convoluted.
As a fix I could move the assignment of has_remote to the new function.

the other error I am not sure. it happens in asyncgits logwalker but reading the small snipped shown by clippy could it be related to adding new properties to status and branchlist? this error only seems to happen on nightly.

@extrawurst
Copy link
Collaborator

@uniqueNullptr2 please update your branch with master, then the nightly errors should be fixed.

... appropriate item to the changelog -> not sure where

Check the changelog, tons of examples there, its a fix, you can do it :)

@extrawurst
Copy link
Collaborator

@uniqueNullptr2 thanks for implementing this. I changed it to not close #1047 because this PR only fixes it for repos without any remote. it does not disable pull on local-only-branches when there is a remote defined

@extrawurst extrawurst merged commit e7f15ae into gitui-org:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status: disable pull cmd on local-only branches
2 participants