Report failure to copy to clipboard #1410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e fewer functions public in commitlist
…red commits instead of looking up items
… instead of ignoring it
…pplication on error
|
Thank you for these improvements! |
IndianBoy42
pushed a commit
to IndianBoy42/gitui
that referenced
this pull request
Jun 4, 2024
* (refactor) move copy_commit_hash from revlog into commitlist, and make fewer functions public in commitlist * (refactor) reduce duplication in commit copying code; use already-stored commits instead of looking up items * (clipboard) actually check subprocess exit status, and report failure instead of ignoring it * (commitlist) display popup with copy failure instead of exiting the application on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request improves failures to copy to clipboard for more system configs.
Right now, when xsel and xclip fail, they return 1 but the status is never checked and execution seems successful.
Additionally, xsel's stderr output sometimes overwrites the screen in random places.
It changes the following:
clipboard::exec_copy_with_argsI followed the checklist:
make checkwithout errors