Windows MSI - add display of file size

[pm100]

not tested by me

[extrawurst]

Cool but can you add it to the CI step that I added please? 😉

[pm100]

you sure you want to run wix everytime? wix is very slow to build ~ 5 mins

[extrawurst]

It looks like it takes ~2.5 min in the CI - Ideen like we can put it in CI until we have one successful release with it and then relax the CI

[extrawurst]

@pm100
do you have an idea why wix prints: WARN: Skipped building the release binary ?

[pm100]

Because we said 'nobuikd' since we just cargo built it. Normally cargo wix would build first Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: Stephan Dilly <notifications@github.com> Sent: Monday, October 26, 2020 1:47:56 AM To: extrawurst/gitui <gitui@noreply.github.com> Cc: pm100 <paulmoore100@hotmail.com>; Mention <mention@noreply.github.com> Subject: Re: [extrawurst/gitui] Windows MSI - add display of file size (#373) @pm100<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpm100&data=04%7C01%7C%7C40227169e599457f377408d8798bd5e9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637392988772015073%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=400IRYrtQBrbH4k8BYJxujNeTcHZGorIirTWWgR0AEs%3D&reserved=0> do you have an idea why wix prints: WARN: Skipped building the release binary ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fextrawurst%2Fgitui%2Fpull%2F373%23issuecomment-716403136&data=04%7C01%7C%7C40227169e599457f377408d8798bd5e9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637392988772015073%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=r4y%2FhU9sQ5gFMx3YQHFPc3Fcc9mjXLkt5afcbReF7lU%3D&reserved=0>, or unsubscribe<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAADXOD37Q6RXPHBVU3C3N7LSMUZTZANCNFSM4S6YGY7Q&data=04%7C01%7C%7C40227169e599457f377408d8798bd5e9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637392988772025067%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=k1NCZ5o8%2FklTXmZFJIwQt%2Fyi2yo5TCLr7a0Rb3LYQDY%3D&reserved=0>.

[extrawurst]

I see so it uses the binary in target instead of building itself? what if both a debug and release one is in target - will it pick release?

[extrawurst]

@pm100 thank you :)