-
Notifications
You must be signed in to change notification settings - Fork 4
Sanitize conda environments #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Reviewer's Guide by SourceryThis PR reorganizes the repository structure by splitting GPU-related code examples into separate directories, each with its own conda environment. The main changes involve removing the global environment.yml file and creating specific environment files for each GPU technology (PyCUDA, CuPy, Numba, Rapids, scikit-cuda). The code examples have been reorganized into dedicated directories with their own README files. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gjbex - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
"id": "e71c1e54-8bd6-4fb1-820d-27b6aea418a6", | ||
"metadata": {}, | ||
"source": [ | ||
"## Requiremnts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick (typo): Fix typo in section heading
"## Requiremnts" | |
"## Requirements" |
[scikit-learn](http://scikit-learn.org/stable/), and aims to provide simple and | ||
efficient access to GPU operations for data science and scientific computing. | ||
|
||
However, the library is aging, and has at least partially been superceded by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (typo): The word 'superceded' should be spelled 'superseded'
However, the library is aging, and has at least partially been superceded by | |
However, the library is aging, and has at least partially been superseded by |
Summary by Sourcery
Sanitize the conda environments by removing the cross-platform environment.yml file and introducing individual environment.yml files for each subdirectory in the source-code directory. Update documentation to reflect changes in the code structure and clarify the usage of GPU computing libraries.
Enhancements:
Documentation: