This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
use PATH_CACHE consistently within determinator.rb #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `PATH_CACHE` was only used by `formatted_last_modified_date` and
not by `last_modified_at`. This resulted in last modified time being
re-determined when using:
{{ page.last_modified_at }}
but not when using:
{% last_modified_at %}
This change aligns the behavior and, as a by product, improves site reset
render performance for users of `page.last_modified_at`. Initial site
generation render performance is unaffected. The tradeoff is that data can get
stale in the cache, and repo information is not reread on reset.
`item.path` returns the absolute path to a file, whereas other instantiations of `Determinator`, like in `tag.rb`, use a relative path. by using a relative path in both places we increase the likelihood of cache hits.
|
👋 Unfortunately, my GitHub notifications for this repository was oddly turned off. I take my responsibility to accepting patches seriously; however, I am just one person, with a very busy life off of GitHub.com! I'm going to close this PR because I like to keep my TODO list scoped and reasonable. This does not mean I will not accept this patch! Rather, it's a way of me asking you if you're still using this gem, and whether you want this PR merged. Just comment back and I'll prioritize it. I assume silence means I can keep it closed. Thanks! this was an automated copy-paste |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
PATH_CACHEwas only used byformatted_last_modified_dateandnot by
last_modified_at. This resulted in last modified time beingre-determined when using:
{{ page.last_modified_at }}
but not when using:
{% last_modified_at %}
This change aligns the behavior and, as a by product, improves site reset
render performance for users of
page.last_modified_at. Initial sitegeneration render performance is unaffected. The tradeoff is that data can get
stale in the cache, and repo information is not reread on reset.
More information available in #85
I did not test extensively but did verify that
bundle exec rake specpassed andbundle exec rake rubocopdid not introduce any new issues.