-
Notifications
You must be signed in to change notification settings - Fork 72
Start overhaul of typehints and TS type definition #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ab7f19e
to
b338c1f
Compare
Hi @allejo, I'm really interested on that 👍 ! The project leaks types definition for typescript, i've started something but it's nearly impossible to maintain with all nodes. I'm glad that you started something. Let me know when you get something to test |
Hey @ichiriac! I had to step away from this PR for a bit, but yea I'll be picking this up again soon and I'll let you know when it's ready to test. When you said the project leaks type definitions, did you mean the current types or this PR? |
bf0b211
to
930f07d
Compare
yo @ichiriac, so I think I've completed as much work I can do in this PR and gotten a reasonably verbose type definition being generated |
Hi @allejo, thanks for your work. I plan to work on the project in few days and I'll release it with your changes. I wish you the best, |
as an FYI, I've added 05fcedd to export |
Hi @allejo sorry for the late, many thanks for your contribution. It will be released in 3.0.3 |
I'm in the process of slowly looking through the codebase and fixing some JSDocs to better generate a TypeScript definitions file.
This is still a WIP, but is this something the project maintainers would be interested in? Currently, working with the generated AST in TS is pretty near impossible for me with the current typing files.