Skip to content

Conversation

allejo
Copy link
Contributor

@allejo allejo commented Aug 3, 2020

I'm in the process of slowly looking through the codebase and fixing some JSDocs to better generate a TypeScript definitions file.

This is still a WIP, but is this something the project maintainers would be interested in? Currently, working with the generated AST in TS is pretty near impossible for me with the current typing files.

@allejo allejo force-pushed the feature/typing-overhaul branch 2 times, most recently from ab7f19e to b338c1f Compare August 5, 2020 07:07
@ichiriac
Copy link
Member

Hi @allejo, I'm really interested on that 👍 ! The project leaks types definition for typescript, i've started something but it's nearly impossible to maintain with all nodes.

I'm glad that you started something. Let me know when you get something to test

@allejo
Copy link
Contributor Author

allejo commented Oct 4, 2020

Hey @ichiriac! I had to step away from this PR for a bit, but yea I'll be picking this up again soon and I'll let you know when it's ready to test.

When you said the project leaks type definitions, did you mean the current types or this PR?

@allejo allejo force-pushed the feature/typing-overhaul branch from bf0b211 to 930f07d Compare December 21, 2020 18:48
@allejo allejo marked this pull request as ready for review December 21, 2020 18:51
@allejo
Copy link
Contributor Author

allejo commented Dec 21, 2020

yo @ichiriac, so I think I've completed as much work I can do in this PR and gotten a reasonably verbose type definition being generated

@ichiriac
Copy link
Member

Hi @allejo, thanks for your work. I plan to work on the project in few days and I'll release it with your changes.

I wish you the best,
Best regards,
Ioan

@allejo
Copy link
Contributor Author

allejo commented Dec 28, 2020

as an FYI, I've added 05fcedd to export Engine yet another way. I can't figure out how to export it by default via JSDoc, so to get the .d.ts file accurate, I added this extra export method...

@ichiriac ichiriac merged commit bb79dcd into glayzzle:master Apr 4, 2021
@ichiriac
Copy link
Member

ichiriac commented Apr 4, 2021

Hi @allejo sorry for the late, many thanks for your contribution. It will be released in 3.0.3

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 96.142% when pulling 8d53922 on allejo:feature/typing-overhaul into 5f9c82c on glayzzle:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants