Skip to content

Conversation

Selion05
Copy link
Contributor

@Selion05 Selion05 commented Apr 30, 2021

@ichiriac @czosel

The Current implementation can handle code like <?php #[Attribute("aoeu",'stnh'),Attribute(),SUP] class Whatever {} as well as named properties <?php #[Attribute(someProp: 'stnh')] class Whatever {}. But it feels like i duplicated logic. Any feedback?

The tokens are equal to token_get_all in php

todo

  • handle \n in attributes
  • tests

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 95.47% when pulling 1239bf8 on Selion05:issue-654-php8-attributes into bb89fff on glayzzle:php8.

@cseufert
Copy link
Collaborator

I have extended this code to product attribute AST nodes for, still a WIP. See #745

@cseufert
Copy link
Collaborator

In #745 I have added support for newlines, and arrays in parameters. Plus parsing into AST

@czosel czosel merged commit b36164a into glayzzle:php8 Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants