Add a few simple math functions to the float module #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
approved these changes
Aug 27, 2020
This adds a function for evaluating exponents for floats. Calls the erlang math module function
|
Sure thing! Updated the changelog, as well as rebased onto main. |
|
Thank you! |
CrowdHailer
reviewed
Sep 3, 2020
| /// ## Examples | ||
| /// | ||
| /// > square_root(4.0) | ||
| /// 2.0 |
There was a problem hiding this comment.
@cschembor3 should this not be Ok(2.0)
There was a problem hiding this comment.
ah you're totally right. Just opened #104 to address this. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR attempts to address some of what was discussed in #100 aimed at the float module.
Implementation
This PR adds the following functions to the float module:
absolute_valuesquare_rootpowerIn terms of implementation,
absis available as a BIF in erlang, so I am just making an external call to that. The square root and power functions were also simple enough that I thought it would be fine to make these external calls to the erlang stdlib as well.Please let me know any thoughts/criticisms/opinions regarding this.